Only center tooltip on small screensizes #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GioSensation
approved these changes
Mar 27, 2023
alistairjcbrown
force-pushed
the
abrown/only-center-tooltip-on-smnaller-screensizes
branch
from
069ce1b
to
68ac1e3
Compare
alistairjcbrown
deleted the
abrown/only-center-tooltip-on-smnaller-screensizes
branch
This was referenced Mar 28, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Apr 12, 2023
Task/Issue URL: Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.3 ## Description Updates Autofill to version [6.4.3](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.4.3). ## What's Changed ### Tests and Tooling - Remove manual server setup in tests by @shakyShane in duckduckgo/duckduckgo-autofill#289 - Add windows release automation by @szanto90balazs in duckduckgo/duckduckgo-autofill#272 - Fix extension release flow by @GioSensation in duckduckgo/duckduckgo-autofill#294 * Update Asana integration to include expected header by @alistairjcbrown in duckduckgo/duckduckgo-autofill#295 ### Bugfixes - Set tooltip initial offscreen position by @alistairjcbrown in duckduckgo/duckduckgo-autofill#291 - Only center tooltip on small screensizes by @alistairjcbrown in duckduckgo/duckduckgo-autofill#290 **Full Changelog**: duckduckgo/duckduckgo-autofill@6.4.1...6.4.3 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: alistairjcbrown <alistairjcbrown@users.noreply.github.com> Co-authored-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1200930669568058/1204260378586823/f
Description
When the tooltip goes offscreen to the left, we center it withiin the window. This usually happens on small screens or iframes. However, there are some sites which have the email input close to the left and which this triggers.
Example: On https://thehustle.co/ with a screensize between 1025px and 1188px
Instead, on larger screensizes (e.g. ones which are as big as two tooltip widths), let's so the same as when we're offscreen on the right and just bring the tooltip back onscreen.
Integration test
Steps to test