Fix a whole bunch of existing failing test cases #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
alistairjcbrown
approved these changes
May 4, 2023
| @@ -109,7 +109,7 @@ <h1 class="bold xs-mb1 xs-text-2">Sign Up To BuzzFeed</h1> | |||
| form signature in host form: 10289224486994181929 | |||
| field frame token: 0685299093D39AE644081FF8F922F684 | |||
| form renderer id: 1 | |||
| field renderer id: 7" data-ddg-testresultelementid="547893" data-manual-scoring="password"> | |||
| field renderer id: 7" data-ddg-testresultelementid="547893" data-manual-scoring="username"> | |||
There was a problem hiding this comment.
❓ Just confirming it's expected that our manual scoring value can be at odds with the details in autofill-information (which say, incorrectly, password)?
There was a problem hiding this comment.
It's expected (though rare). That was added by Chrome during the comparison project. We left it for reference, but we shouldn't rely on it.
| section: fakeemailremembered_0_15 | ||
| field signature: 475301429 | ||
| form signature: 9486430941283870347 | ||
| form signature in host form: 9486430941283870347 | ||
| field frame token: EE88768FD088DBFD37B69597958CA8DC | ||
| form renderer id: 3 | ||
| field renderer id: 20" data-ddg-testresultelementid="582940" data-manual-scoring="password"> | ||
| field renderer id: 20" data-ddg-testresultelementid="582940"> |
There was a problem hiding this comment.
❓ Is the manual scoring removed as this input is not longer matched?
There was a problem hiding this comment.
Correct. We don't want to match this as it's a hidden dummy field they use internally, it's not shown to users and we explicitly try to skip it.
This was referenced May 4, 2023
This was referenced May 5, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
May 8, 2023
Task/Issue URL: https://app.asana.com/0/1204538113123459/1204538113123459 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.5.1 ## Description Updates Autofill to version [6.5.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/6.5.1). ### Autofill 6.5.1 release notes ## What's Changed * Disable pixel for all platforms but extension by @GioSensation in duckduckgo/duckduckgo-autofill#309 * Fix release script for BSK by @GioSensation in duckduckgo/duckduckgo-autofill#310 Included in 6.5.0: - Improve debugging by @GioSensation in duckduckgo/duckduckgo-autofill#293 - Reduce the calls on check position when there are many mutations by @alistairjcbrown in duckduckgo/duckduckgo-autofill#288 - Window release fetch tags before checkout by @alistairjcbrown in duckduckgo/duckduckgo-autofill#296 - Autofill compare generated test suites by @greyivy in duckduckgo/duckduckgo-autofill#283 - Update release scripts with latest Apple tooling by @GioSensation in duckduckgo/duckduckgo-autofill#299 - Add temporary incontext_eligible pixel by @GioSensation in duckduckgo/duckduckgo-autofill#304 - Fix double-click issue by @GioSensation in duckduckgo/duckduckgo-autofill#306 - Fix a whole bunch of existing failing test cases by @GioSensation in duckduckgo/duckduckgo-autofill#308 **Full Changelog**: duckduckgo/duckduckgo-autofill@6.5.0...6.5.1 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: GioSensation <GioSensation@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @alistairjcbrown
Asana: https://app.asana.com/0/0/1204529098552468/f
Description
Just a bunch of fixes for known issues.
Steps to test
This literally fixes known test failures 🙂.