Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ema/fix release again #311

Merged
merged 2 commits into from
May 5, 2023
Merged

Ema/fix release again #311

merged 2 commits into from
May 5, 2023

Conversation

GioSensation
Copy link
Member

Reviewer: @alistairjcbrown @szanto90balazs

Description

  • Removes the extension Asana creation task (handled by a separate workflow)
  • Fixes the Windows workflow (submodules were not initialized properly on checkout). See this job failure.

@GioSensation
Remove extension from the Asana release scripts
c1ca607 
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation
Fix submodule initialization for Windows release
0bf093e 
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation GioSensation self-assigned this May 5, 2023
@GioSensation GioSensation requested review from alistairjcbrown and szanto90balazs and removed request for alistairjcbrown May 5, 2023 10:00
@GioSensation GioSensation merged commit 49334cc into main May 5, 2023
@GioSensation GioSensation deleted the ema/fix-release-again branch May 5, 2023 11:58
This was referenced May 10, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szanto90balazs szanto90balazs szanto90balazs approved these changes

@alistairjcbrown alistairjcbrown Awaiting requested review from alistairjcbrown

Assignees

@GioSensation GioSensation

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GioSensation @szanto90balazs