Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release workflow #313

Merged
merged 3 commits into from
May 10, 2023
Merged

Update release workflow #313

merged 3 commits into from
May 10, 2023

Conversation

alistairjcbrown
Copy link
Member

Reviewer: @GioSensation
Asana: https://app.asana.com/0/1198964220583541/1203931336731295/f

Description

Updates to release workflow to split sections into separate jobs which can pass or fail independently.

Steps to test

See last commit for dry-run version
Last dry-run -- https://github.com/duckduckgo/duckduckgo-autofill/actions/runs/4894548018
image

@alistairjcbrown alistairjcbrown changed the title Abrown/update release flow Uupdate release workflow May 5, 2023
@alistairjcbrown alistairjcbrown changed the title Uupdate release workflow Update release workflow May 5, 2023
@alistairjcbrown alistairjcbrown mentioned this pull request May 7, 2023
Closed
@alistairjcbrown
Copy link
Member Author

Add the test workflow to documentation so we've an example of how this was done

GioSensation
GioSensation approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge and test once checking the things we discussed yesterday, it's the only way to know how it will fail 😅. Thanks a ton for this, will remove a ton of stress from releases!

@alistairjcbrown alistairjcbrown merged commit 466e369 into main May 10, 2023
@alistairjcbrown alistairjcbrown deleted the abrown/update-release-flow branch May 10, 2023 15:20
This was referenced May 10, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GioSensation GioSensation GioSensation approved these changes

@shakyShane shakyShane Awaiting requested review from shakyShane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alistairjcbrown @GioSensation