Prevent invalid links in update task script #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asana rejected input with invalid href values for links, which this script was previously doing whenever the PR URL was missing. Update this fail gracefully.
alistairjcbrown
commented
May 11, 2023
| const markup = | ||
| `${wrapInLi(getLink(prUrls.ios, 'iOS PR'))}${wrapInLi(getLink(prUrls.macos, 'macOS PR'))}` | ||
| taskDescriptionSubstitutions.push( | ||
| [/\[\[extra_content]]/, markup] |
There was a problem hiding this comment.
Let me know if I've made a mistake here, but it seemed strange that here we didn't replace the wrapping <li>, but below we did -- surely we'd want to replace it both times? (either to replace it with the two bullet points created above, or to remove it completely)
There was a problem hiding this comment.
Mhm, not 100% sure, but we'll see when it runs.
GioSensation
approved these changes
May 15, 2023
| const markup = | ||
| `${wrapInLi(getLink(prUrls.ios, 'iOS PR'))}${wrapInLi(getLink(prUrls.macos, 'macOS PR'))}` | ||
| taskDescriptionSubstitutions.push( | ||
| [/\[\[extra_content]]/, markup] |
There was a problem hiding this comment.
Mhm, not 100% sure, but we'll see when it runs.
alistairjcbrown
deleted the
abrown/prevent-invalid-links-in-update-task-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1198964220583541/1204575576128585/f
Description
Asana rejected input with invalid href values for links, which this script was previously doing whenever the PR URL was missing. Update this fail gracefully.
Failure example: https://github.com/duckduckgo/duckduckgo-autofill/actions/runs/4938719133/jobs/8828855242
Steps to test
Unit test included