Fix minor regression #320
Fix minor regression #320
Conversation
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
| setTimeout(() => { | ||
| this.attach(args) | ||
| }, 50) | ||
| return |
There was a problem hiding this comment.
Instead of having the side-effect happen after a timeout, now we are calling this same function recursively after the timeout. This ensures that this.#state is consistent across calls. The 500 delay was likely arbitrary and 50 works just as well, so shorter is better.
There was a problem hiding this comment.
@GioSensation NAB: Do we want to provide a comment for context on the 50 value to help future us? (i.e. it's just some value to throttle repeated calls)
There was a problem hiding this comment.
I've added a comment above to explain why we're recursing, plus that the 50 is arbitrary.
| setTimeout(() => { | ||
| this.attach(args) | ||
| }, 50) | ||
| return |
There was a problem hiding this comment.
@GioSensation NAB: Do we want to provide a comment for context on the 50 value to help future us? (i.e. it's just some value to throttle repeated calls)
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
… ema/fix-focus-regression Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com> # Conflicts: # dist/autofill-debug.js # dist/autofill.js # swift-package/Resources/assets/autofill-debug.js # swift-package/Resources/assets/autofill.js
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Reviewer: @alistairjcbrown
Asana: https://app.asana.com/0/0/1204595906186359/f
Description
This fixes a minor use case of tabbing from field to field when the form overflows the viewport.
Steps to test
Added test case and verified on device. Steps to test: