Other minor fixes #328
Merged
Other minor fixes #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
GioSensation
commented
Jun 1, 2023
| @@ -41,7 +41,7 @@ class FormAnalyzer { | |||
| */ | |||
| this.signals = [] | |||
|
|
|||
| this.evaluateElAttributes(input, 3, true) | |||
| this.evaluateElAttributes(input, 1, true) | |||
There was a problem hiding this comment.
This has a very minor impact, rightly so, and it's lowered further here. It's a legacy from the very first implementation when we were only expecting single-field forms and in fact it only runs on the very first field we encounter for each form. I played around with it, trying to actually run this on all input fields, removing it, etc. Ultimately, keeping it for only one field and lowering its impact yielded the best result.
GioSensation
commented
Jun 1, 2023
| @@ -382,7 +382,7 @@ <h3>Enjoy with signing in</h3> | |||
| form signature in host form: 14398989862180533438 | |||
| field frame token: 5AE7930B5E80C2ACB53A029D04125578 | |||
| form renderer id: 0 | |||
| field renderer id: 30" data-ddg-testresultelementid="552903" data-manual-scoring="username"> | |||
| field renderer id: 30" data-ddg-testresultelementid="552903" data-manual-scoring="emailAddress"> | |||
There was a problem hiding this comment.
Miscategorized previously because of multiple forms in the page.
This was referenced Jun 2, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Jun 19, 2023
Task/Issue URL: https://app.asana.com/0/1204742406448894/1204742406448894 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/7.2.0 ## Description Updates Autofill to version [7.2.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/7.2.0). ### Autofill 7.2.0 release notes ## What's Changed * Fix Windows UI line bug by @greyivy in duckduckgo/duckduckgo-autofill#325 * Remove separator above Duck Address whenever it's first item by @alistairjcbrown in duckduckgo/duckduckgo-autofill#329 * macOS support for in-context signup by @alistairjcbrown in duckduckgo/duckduckgo-autofill#317 * Other minor fixes by @GioSensation in duckduckgo/duckduckgo-autofill#328 **Full Changelog**: duckduckgo/duckduckgo-autofill@7.1.0...7.2.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: alistairjcbrown <alistairjcbrown@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @alistairjcbrown
Asana: https://app.asana.com/0/0/1204734329088502/f
Description
Minor fixes:
Steps to test