Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marking flaky tests #524

Merged
merged 1 commit into from
Mar 7, 2024
Merged

marking flaky tests #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/playwright-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@ await emailPage.clickIntoInput()
npm run test:integration
```

## Running only flaky tests

```shell
npm run test:integration -- --grep '@flaky'
```

## Running everything BUT flaky tests

```shell
npm run test:integration -- --grep-invert '@flaky'
```

---

# Workflows
Expand Down
4 changes: 2 additions & 2 deletions integration-test/tests/email-autofill.extension.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {emailAutofillPage} from '../helpers/pages/emailAutofillPage.js'
const test = testContext(base)

test.describe('chrome extension', () => {
test('should autofill the selected email', async ({page}) => {
test('should autofill the selected email @flaky', async ({page}) => {
const {personalAddress, privateAddress0, privateAddress1} = constants.fields.email

forwardConsoleMessages(page)
Expand Down Expand Up @@ -68,7 +68,7 @@ test.describe('chrome extension', () => {
])
})

test('should not close the modal when autofilling', async ({page}) => {
test('should not close the modal when autofilling @flaky', async ({page}) => {
const {personalAddress} = constants.fields.email

forwardConsoleMessages(page)
Expand Down
2 changes: 1 addition & 1 deletion integration-test/tests/email-autofill.macos.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ test.describe('macos', () => {
username: constants.fields.email.privateAddress0
})
})
test('using a private address, but then editing it', async ({page}) => {
test('using a private address, but then editing it @flaky', async ({page}) => {
await forwardConsoleMessages(page)
const signup = signupPage(page)

Expand Down
4 changes: 2 additions & 2 deletions integration-test/tests/login-form.macos.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ test.describe('Auto-fill a login form on macOS', () => {
await login.assertFocusMessage()
})
})
test('by clicking a label', async ({page}) => {
test('by clicking a label @flaky', async ({page}) => {
await testLoginPage(page, {clickLabel: true, pageType: 'loginWithText'})
})
test('selecting an item inside an overlay', async ({page}) => {
Expand Down Expand Up @@ -314,7 +314,7 @@ test.describe('Auto-fill a login form on macOS', () => {
})

test.describe('When the form is in a modal', () => {
test('Filling the form should not close the modal', async ({page}) => {
test('Filling the form should not close the modal @flaky', async ({page}) => {
const login = await createLoginFormInModalPage(page)
await login.openDialog()
await login.fieldsContainIcons()
Expand Down
Loading