[Credentials import] If no details are available don't show the tooltip #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
force-pushed
the
dbajpeyi/import-promotion-empty-tooltip
branch
from
9682051
to
e9a0b02
Compare
1 task
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Sep 11, 2024
Task/Issue URL: https://app.asana.com/0/1208264544627947/1208264544627947 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/13.1.0 ## Description Updates Autofill to version [13.1.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/13.1.0). ### Autofill 13.1.0 release notes ## What's Changed https://app.asana.com/0/72649045549333/1201480346793878/f Adding password import promotion support. There are no breaking API changes, hence minor version bump! * Update password-related json files (2024-08-15) by @daxmobile in duckduckgo/duckduckgo-autofill#632 * Update password-related json files (2024-08-29) by @daxmobile in duckduckgo/duckduckgo-autofill#644 * Update password-related json files (2024-08-30) by @daxmobile in duckduckgo/duckduckgo-autofill#645 * Update password-related json files (2024-09-03) by @daxmobile in duckduckgo/duckduckgo-autofill#646 * [Autofill] Introduce password import promotion prompt in autofill.js by @dbajpeyi in duckduckgo/duckduckgo-autofill#631 * [Locales] Credentials import by @dbajpeyi in duckduckgo/duckduckgo-autofill#647 * [Credentials Import] remove API response by @dbajpeyi in duckduckgo/duckduckgo-autofill#648 * [Credentials Import] Check local credentials before showing prompt by @dbajpeyi in duckduckgo/duckduckgo-autofill#650 * [Credentials import] If no details are available don't show the tooltip by @dbajpeyi in duckduckgo/duckduckgo-autofill#649 **Full Changelog**: duckduckgo/duckduckgo-autofill@12.2.0...13.1.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: dbajpeyi <3018923+dbajpeyi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana:
Description
There was a bug in the import promotion tooltip, that whenever there is an empty import, we end up opening the tooltip with no data:
This PR fixes that in the
shouldOpenTooltipcall. Here it merges the check together with in context signup.Steps to test
import-flow-fix.mp4