[Credentials Import] Add "Don't Show Again" button to import prompt #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
force-pushed
the
dbajpeyi/feature/dismiss-password-import-flow
branch
from
4c04430
to
cc23669
Compare
dbajpeyi
changed the title
dbajpeyi
force-pushed
the
dbajpeyi/feature/dismiss-password-import-flow
branch
from
177bf7a
to
45f6716
Compare
dbajpeyi
commented
Oct 10, 2024
| @@ -215,7 +215,7 @@ | |||
| color: #FFFFFF; | |||
| } | |||
|
|
|||
| .tooltip__button--manage { | |||
| .tooltip__button--secondary { | |||
There was a problem hiding this comment.
Just renaming it to sound more "reusable", just because we have the same scenario (manage password + don't show again) kind of like a secondary button.
GioSensation
approved these changes
Oct 11, 2024
| @@ -215,7 +215,7 @@ | |||
| color: #FFFFFF; | |||
| } | |||
|
|
|||
| .tooltip__button--manage { | |||
| .tooltip__button--secondary { | |||
src/CredentialsImport.js
Outdated
Comment on lines
63
to
64
| this.device.deviceApi.notify(new CloseAutofillParentCall(null)) | ||
| this.device.deviceApi.notify(new CredentialsImportFlowPermanentlyDismissedCall(null)) |
There was a problem hiding this comment.
Just a thought. Here we call close, then the other call (same as we do above in line 58). Is there a race condition where the first call's side effect is so quick that the second call never happens because then the webview gets closed and the js context is destroyed? Should we flip their order?
There was a problem hiding this comment.
That's a good point! I think it's safer to do flipped order. Changed it in 79c1941
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1205996472158114/1208381175784446/f
Description
As the Win and Mac plan to release this prompt to existing users and updating some heuristics to be more persistent, we are adding new UI and API call for dismissing credentials import dialog. Introduces a new API call.
Steps to test
graeme/enable-import-prompt-for-all-userson MacOS browser,