Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getBreakageFormOptions message handler #2866

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Dec 19, 2024

The privacy-dashboard is going to be sending a new message
"getBreakageFormOptions", which is very similar to "getToggleReportOptions"
except for use by the standard breakage report UI flow. Let's add that now,
taking care to share the logic between those message handlers.

Reviewer: @jdorweiler, @mgurgel

Steps to test this PR:

  1. Disable protections for a website, then click to see report details.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

The privacy-dashboard is going to be sending a new message
"getBreakageFormOptions", which is very similar to "getToggleReportOptions"
except for use by the standard breakage report UI flow. Let's add that now,
taking care to share the logic between those message handlers.
@kzar kzar requested review from mgurgel and jdorweiler December 19, 2024 19:43
@kzar kzar merged commit 019708a into duckduckgo:main Dec 19, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants