Skip to content
iOS - PR Checks

Refactor app startup code - extracting services #655

Sign in to view logs

Refactor app startup code - extracting services

Refactor app startup code - extracting services #655

Triggered via pull request February 10, 2025 17:40
@jaceklypjaceklyp
synchronize #3859
jacek/refactor-app-delegate-milestone-2
Status Failure
Total duration 9m 59s
Artifacts –

ios-pr-checks.yml

on: pull_request
SwiftLint
37s
SwiftLint
ShellCheck
7s
ShellCheck
Unit Tests
9m 47s
Unit Tests
Make Release Build
8m 45s
Make Release Build
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

1 error, 22 warnings, and 10 notices
SwiftLint: DuckDuckGo/AppServices/SubscriptionService.swift#L76
Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L288
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L68
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L90
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L131
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L161
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L288
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L68
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build
xcbeautify 2.23.0 is already installed and up-to-date. To reinstall 2.23.0, run: brew reinstall xcbeautify
Unit Tests
xcbeautify 2.23.0 is already installed and up-to-date. To reinstall 2.23.0, run: brew reinstall xcbeautify
Unit Tests: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Unit Tests: Core/StatisticsLoader.swift#L68
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L90
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L131
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L161
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/Pixel.swift#L288
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
Unit Tests
Background color ‘WidgetBackground’ is not present in any asset catalogs.
Unit Tests: DuckDuckGo/FavoritesDisplayMode+UserDefaults.swift#L23
extension declares a conformance of imported type 'FavoritesDisplayMode' to imported protocol 'LosslessStringConvertible'; this will not behave correctly if the owners of 'Bookmarks' introduce this conformance in the future
Unit Tests: DerivedData/Build/Intermediates.noindex/DuckDuckGo-iOS.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L409
The "CreditCard-32-Color" image asset name resolves to the symbol "creditCard32" which already exists. Try renaming the asset.
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenCallActionOnOnboardingFinalDialog_ThenDidTapDismissContextualOnboardingActionOnDelegateIsCalled
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewFire_ThenReturnViewOnboardingFireDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasNotShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForFinalSpec_ThenReturnViewOnboardingFinalDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasNotShown_ThenActionCallsDidAcknowledgeContextualOnboardingTrackersDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasShown_ThenActionCallsDidTapDismissContextualOnboardingAction
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_ThenReturnViewOnboardingTrackersDoneDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForVisitWebsiteSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenNavigateToActionIsCalledOnDelegate