Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BSK pin to update C-S-S to 3.1.0 #1331

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Conversation

dharb
Copy link
Collaborator

@dharb dharb commented Oct 6, 2022

Ignore the branch name, C-S-S had a new release in the time between me making the branch and submitting this PR.

Task/Issue URL: duckduckgo/BrowserServicesKit#147 https://app.asana.com/0/0/1203119375983397/f
Tech Design URL: https://app.asana.com/0/481882893211075/1202892347914977/f
CC: @samsymons

Description:
This is primarily to ship the element hiding content script feature, which is only active on macOS.

Steps to test this PR:

  1. See Collapse empty ad spaces (element hiding) content-scope-scripts#155

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

ignore the branch name, C-S-S had a new release in the time between me making the branch and submitting this PR
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samsymons samsymons assigned dharb and unassigned samsymons Oct 7, 2022
@dharb dharb added the dependencies Pull requests that update a dependency file label Oct 7, 2022
@dharb dharb merged commit 7fabdbc into duckduckgo:develop Oct 7, 2022
@dharb dharb deleted the patch-2 branch October 7, 2022 16:10
bershanskiy pushed a commit to bershanskiy/duckduckgo-iOS that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants