Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageLoads attribution pixel #1862

Merged
merged 4 commits into from
Jul 28, 2023
Merged

PageLoads attribution pixel #1862

merged 4 commits into from
Jul 28, 2023

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Jul 25, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1203017403159775/f

Description:
Class to track and aggregate the number of page loads that have had an active exemption within a specified time period.

Steps to test this PR:

  1. Run tests
  2. Visit attribution sites - make sure the pageLoadsCount increases by 1
  3. Go back and forward, visit the same vendor and notice the counter does not increase
  4. Visit another vendor or open new tab and visit same vendor site - the counter should increase
  5. Change the sendInterval const to notice that pixels is sent and the stats are reseted.

@jaceklyp jaceklyp mentioned this pull request Jul 25, 2023
Merged
@jaceklyp jaceklyp requested a review from bwaresiak July 25, 2023 12:29
bwaresiak
bwaresiak approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaceklyp added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 28, 2023
@jaceklyp
Attribution pixel (#432)
f255099 
Task/Issue URL: https://app.asana.com/0/414235014887631/1203017403159775/f
iOS PR: duckduckgo/iOS#1862
macOS PR: duckduckgo/macos-browser#1388

Description:
Class that aggregates detected Ad Attributions on a websites and stores that count over a certain time interval.
@jaceklyp jaceklyp merged commit 3a5f2f1 into develop Jul 28, 2023
5 checks passed
@jaceklyp jaceklyp deleted the jacek/attribution-pixels branch July 28, 2023 13:32
afterxleep pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 2, 2023
@jaceklyp @afterxleep
Attribution pixel (#432)
89ec4fb 
Task/Issue URL: https://app.asana.com/0/414235014887631/1203017403159775/f
iOS PR: duckduckgo/iOS#1862
macOS PR: duckduckgo/macos-browser#1388

Description:
Class that aggregates detected Ad Attributions on a websites and stores that count over a certain time interval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

Assignees

@bwaresiak bwaresiak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaceklyp @bwaresiak