Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_log fixes #1875

Merged
merged 12 commits into from
Aug 2, 2023
Merged

os_log fixes #1875

merged 12 commits into from
Aug 2, 2023

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jul 28, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1205157723964854/f
BSK PR: duckduckgo/BrowserServicesKit#437

Description:

  • fixes "implicit import" warning
  • fixes "" message in Console app for interpolated messages
  • outputs .debug messages to Console app for DEBUG builds

Steps to test this PR:

  1. Validate macOS & iOS projects build&run, there shouldn‘t be "implicit import" warning for the .disabled OSLog default arguments
  2. add interpolated os_log output, validate it‘s shown in Console app: os_log("some interpolated \(value)")
  3. validate .debug level os_log is shown in Console app: os_log("test debug message", type: .debug)

@mallexxx mallexxx mentioned this pull request Jul 28, 2023
Merged
2 tasks
@miasma13 miasma13 self-requested a review August 1, 2023 10:28
@miasma13 miasma13 self-assigned this Aug 1, 2023
miasma13
miasma13 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as Expected 👍

mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 2, 2023
@mallexxx
os_log fixes (#437)
289d6fe 
Task/Issue URL: https://app.asana.com/0/414235014887631/1205157723964854/f
iOS PR: duckduckgo/iOS#1875
macOS PR: duckduckgo/macos-browser#1406

* os_log fixes

* add log visibility modifier to interpolated os_log

* fix os_log overloads
@mallexxx mallexxx merged commit ad3cb98 into develop Aug 2, 2023
1 of 5 checks passed
@mallexxx mallexxx deleted the alex/os_log-fixes branch August 2, 2023 07:24
afterxleep pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 2, 2023
@mallexxx @afterxleep
os_log fixes (#437)
7c5a0bc 
Task/Issue URL: https://app.asana.com/0/414235014887631/1205157723964854/f
iOS PR: duckduckgo/iOS#1875
macOS PR: duckduckgo/macos-browser#1406

* os_log fixes

* add log visibility modifier to interpolated os_log

* fix os_log overloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

Assignees

@miasma13 miasma13

Labels
includes-BSK-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @miasma13