Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soft revert history suggestions #2711

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Apr 11, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207038972999258/f
Tech Design URL:
CC:

Description:
Reverts change to new logic for existing users not in the experiment.

Steps to test this PR:

  1. Run the app and check you're not allocated to a variant (e.g. because you're a return user, which should be the case unless you reset the simulator) - the output from Xcode will say
  2. Ensure previous logic works, ie matching bookmarks should appear in the top two slots of suggestions.
  3. Run the app with the md variant (via launch arguments)
  4. Ensure new logic with history works
  5. Run the app with the mc variant
  6. Ensure new logic without history works
  7. Reset the simulator so you're a new user and check you get allocated to a variant

@brindy brindy requested a review from dus7 April 11, 2024 11:04
@brindy brindy force-pushed the brindy/soft-revert-history-suggestions branch from 6e5e824 to 19441b3 Compare April 11, 2024 11:22
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit 2f1f4ea into release/7.115.0 Apr 11, 2024
13 checks passed
@brindy brindy deleted the brindy/soft-revert-history-suggestions branch April 11, 2024 12:10
samsymons added a commit that referenced this pull request Apr 12, 2024
# By Mariusz Śpiewak (4) and others
# Via Chris Brind (1) and others
* main:
  Reverting accidental push to main (#2718)
  Add SubscriptionContainerViewModel and
  Manually hide loader + Pixel (#2687)
  Release 7.115.0-2 (#2712)
  soft revert history suggestions (#2711)
  Bring back accessibility identifiers for onboarding buttons (#2709)
  BSK release 133.1.0 (#2708)
  Password Manager widget and app shortcut (#2619)
  Release 7.115.0-1 (#2707)
  Update set-as-default onboarding illustration for dark mode (#2694)
  update app store prompt logic (#2678)
  Fix status bar color on regular width size class (#2705)
  Updated settings (#2603)
  Update BSK with autofill 11.0.1 (#2704)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Apr 15, 2024
# By Daniel Bernal (33) and others
# Via Mariusz Śpiewak (5) and others
* main: (245 commits)
  Fix inconsistent bars state when scrolling (#2733)
  fix tests (#2732)
  Release 7.115.0-4 (#2729)
  Fix VPN denial prompt loop (#2728)
  Small UI Fixes for subscriptions (#2690)
  SPM updated: SwiftSoup, Lottie, ZIPFoundation (#2724)
  Release 7.115.0-3 (#2727)
  VPN: Specific TunnelController start failure reporting (#2714)
  update bsk dependency (#2725)
  Subscriptions: Fix thread issue on Subscription Restore (#2719)
  Manage ‘Stale’ PRs (#2723)
  maestro: hide dax dialogs if visible and cancel keyboard after fireproof (#2695)
  Remove timezone offset from the VPN server object (#2701)
  Reverting accidental push to main (#2718)
  Add SubscriptionContainerViewModel and
  Manually hide loader + Pixel (#2687)
  Release 7.115.0-2 (#2712)
  soft revert history suggestions (#2711)
  Bring back accessibility identifiers for onboarding buttons (#2709)
  BSK release 133.1.0 (#2708)
  ...

# Conflicts:
#	Core/Pixel.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants