Keep Remote Messages in database if they were shown #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ayoy
commented
Jul 24, 2024
| @@ -264,7 +264,7 @@ | |||
| <rect key="frame" x="0.0" y="0.0" width="383.5" height="44.5"/> | |||
| <autoresizingMask key="autoresizingMask"/> | |||
| </tableViewCellContentView> | |||
| <listContentConfiguration key="contentConfiguration" text="Remote Messages" secondaryText=""/> | |||
| <listContentConfiguration key="contentConfiguration" text="Remote Messaging Framework" secondaryText=""/> | |||
There was a problem hiding this comment.
Believe me or not, but this is the only change I made to the storyboard 😅
|
|
||
| // call didAppear here to support marking messages as shown when they appear on the new tab page | ||
| // as a result of refreshing a config while the user was on a new tab page already. | ||
| onDidAppear() |
There was a problem hiding this comment.
It's fishy, but it works. That said, a remote message appearing on user's new tab page is a rare situation (normally they will appear at app startup after being refreshed in background).
samsymons
approved these changes
Jul 24, 2024
samsymons
added a commit
that referenced
this pull request
Jul 26, 2024
# By Dominik Kapusta (2) and others # Via GitHub * main: Add favorites empty state tooltip (#3119) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113) iOS 14 deprecation cleanup (#3098) Update Xcode version to 15.4 (#3142) remove pixels for keyboard toggle (#3135) Keep Remote Messages in database if they were shown (#3136) # Conflicts: # DuckDuckGo/SettingsViewModel.swift
samsymons
added a commit
that referenced
this pull request
Jul 28, 2024
# By Daniel Bernal (3) and others # Via GitHub * main: [DuckPlayer] 13. Add openInfo message to Overlay (#3151) [DuckPlayer] 12. Ensure DuckPlayer does not leak without the proper config (#3147) [DuckPlayer] 11. Tab views and Pixel updates (#3145) Remove the NETWORK_PROTECTION compilation flag (#3139) Add favorites empty state tooltip (#3119) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113) iOS 14 deprecation cleanup (#3098) Update Xcode version to 15.4 (#3142) remove pixels for keyboard toggle (#3135) Keep Remote Messages in database if they were shown (#3136) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207619243206445/1207864976004819/f
Description:
Update RemoteMessagingStore to keep track of messages that have ever been shown to the user,
also if the user didn't interact with them (by dismissing or clicking any buttons).
Additionally, upgrade RMF debug view with a button to refetch the config and a bit nicer view
of remote messages in the database.
Steps to test this PR:
See this Asana task.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template