Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize autofill security concern mitigation copy #3379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Localize autofill security concern mitigation copy #3379

wants to merge 1 commit into from
+288 −144

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Sep 20, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1199230911884351/1208341864628593/f

Description:

Localizations for https://app.asana.com/0/1199230911884351/1208316169332403

Steps to test this PR:

  1. Switch to another language and step through the screens from here to check they've been translated

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme requested a review from amddg44 September 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amddg44 amddg44 Awaiting requested review from amddg44

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@graeme