Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Chat handoff #3785

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

AI Chat handoff #3785

wants to merge 16 commits into from

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 9, 2025

Task/Issue URL: https://app.asana.com/0/1204167627774280/1209119202522826/f

Description:
Add handoff support using the C-S-S communication layer

Steps to test this PR:
This feature depends on some FE changes in the SERP, so to test it you'll need to do a bit of initial setup:

  1. Use this privacy config
  2. Host this locally and expose it via ngrok (the config file above is setup to allow the ngrok-free domain, feel free to adjust if you're using something else)
  3. Apply this patch which will: Remove the webview callback from within the AI Chat custom view, setup the ngrok URL

  1. Open the test website, tap on "open with payload". Validate that the AI chat view displays a large payload
  2. Open the test website, tap on "open without payload". Validate that the AI chat view display null payload
  3. Open the test website, tap on "open with random payload". Validate that the AI chat view display a random payload each time (Do this a couple times)
  4. When doing the above, you can also validate if the payload is correctly consume by tapping on "Update settings".

Copy link

github-actions bot commented Jan 9, 2025

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 3f4301f

@Bunn Bunn marked this pull request as ready for review January 10, 2025 17:19
@Bunn Bunn changed the title WIP: AI Chat handoff AI Chat handoff Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant