Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] shared web tests #3933

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

[Draft] shared web tests #3933

wants to merge 28 commits into from
+549 −41

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Feb 6, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1208763070373634
Tech Design URL:
CC:

Description:

Draft as dependent repo isn't open yet.
Code for that is here: duckduckgo/shared-web-tests@main...jkt/webdriver

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against af83c26

@jonathanKingston jonathanKingston force-pushed the jkt/shared-web-tests branch 2 times, most recently from 8835f37 to b3bb0a4 Compare February 6, 2025 09:21
@duckduckgo duckduckgo deleted a comment from dailan2009 Feb 11, 2025
brindy
brindy reviewed Feb 11, 2025
View reviewed changes
DuckDuckGo/AutomationServer.swift
case .ready:
break // Connection is valid, continue
case .cancelled, .failed:
print("Connection is no longer valid \(connection.state) \(String(describing: error)) \(String(describing: content)).")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this print with logging (other places too)

brindy
brindy reviewed Feb 11, 2025
View reviewed changes
@jonathanKingston jonathanKingston mentioned this pull request Feb 18, 2025
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @brindy