Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable most cron workflows #3962

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Feb 13, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209393516054365
Tech Design URL:
CC:

Description:

This PR disables all cron workflow triggers except for stale PRs, since that one isn't important in this context. The goal here is to disable cron triggers after the monorepo migration, avoiding noise in Asana etc.

This PR is not to be merged until Feb 17 (most likely I will merge it on my Feb 16 evening).

Steps to test this PR:

  1. Check that no cron jobs are remaining (except for stale PRs which can stay enabled)

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samsymons samsymons merged commit 809bb6c into main Feb 15, 2025
25 checks passed
@samsymons samsymons deleted the sam/disable-cron-workflow-triggers branch February 15, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants