Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic for extracting Asana task ID #3966

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Feb 13, 2025

Task/Issue URL: https://app.asana.com/0/1199333091098016/1209401276129396
Tech Design URL:
CC:

Description:

This PR fixes the Asana comment functionality of the iOS ad-hoc workflow.

Steps to test this PR:

  1. Check that this workflow run successfully commented to Asana here

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from kshann February 13, 2025 19:07
Copy link
Contributor

@kshann kshann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could use inputs. only since it's dispatched.

@samsymons samsymons merged commit ca8db9b into main Feb 13, 2025
14 checks passed
@samsymons samsymons deleted the sam/fix-adhoc-asana-posts branch February 13, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants