Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Search Header experiment code #834

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Remove Search Header experiment code #834

merged 1 commit into from
Feb 16, 2021

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/856498667320406/1194658054793361
Tech Design URL:
CC:

Description:
Remove Double search header experiment and enable that feature.

Steps to test this PR:

  1. Ensure other experiments are allocated as expected.
  2. Check whether SERP/URL bar is working as expected.

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPad

OS Testing:

  • iOS 11
  • iOS 12
  • iOS 13
  • iOS 14

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy self-assigned this Feb 16, 2021
brindy
brindy approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwaresiak
Copy link
Collaborator Author

Thank you @brindy !

@bwaresiak bwaresiak merged commit ce492ac into develop Feb 16, 2021
@bwaresiak bwaresiak deleted the feature/bartek/remove-experiment branch February 16, 2021 16:19
samsymons added a commit that referenced this pull request Feb 17, 2021
@samsymons
Merge branch 'develop' into spike/sam/favicon-fetching-improvements
939bb4e 
* develop:
  Remove experiment code (#834)
  Fix potential memory leak in BloomFilterWrapper (#833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

@samsymons samsymons Awaiting requested review from samsymons

@THISISDINOSAUR THISISDINOSAUR Awaiting requested review from THISISDINOSAUR

Assignees

@brindy brindy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwaresiak @brindy