Skip to content

Do not use suggestion view controller visibility to set suggestion #14047

Do not use suggestion view controller visibility to set suggestion

Do not use suggestion view controller visibility to set suggestion #14047

Triggered via pull request November 7, 2024 18:32
Status Failure
Total duration 16m 41s
Billable time 42m
Artifacts 6

pr.yml

on: pull_request
Matrix: Test
SwiftLint
46s
SwiftLint
Test Shell Scripts
17s
Test Shell Scripts
Make Release Build
10m 43s
Make Release Build
Verify autoconsent bundle
0s
Verify autoconsent bundle
ShellCheck
9s
ShellCheck
Private API Report  /  Update PR comment
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

15 errors, 37 warnings, and 1 notice
SwiftLint: DuckDuckGo/Sync/SyncDiagnosisHelper.swift#L56
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
Test (Non-Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L420
testWhenDeactivatingAddressBar_webViewShouldBecomeFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.AddressBarTextEditor: 0x125e96400>
Test (Non-Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L420
testWhenDeactivatingAddressBar_webViewShouldBecomeFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.AddressBarTextEditor: 0x12599f500>
Test (Non-Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L420
testWhenDeactivatingAddressBar_webViewShouldBecomeFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.AddressBarTextEditor: 0x125a36210>
Test (Non-Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L743
testWhenPageRedirected_addressBarStaysActivePreservingUserInput, XCTAssertEqual failed: ("") is not equal to ("https://duckduckgo.com/")
Test (Non-Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L743
testWhenPageRedirected_addressBarStaysActivePreservingUserInput, XCTAssertEqual failed: ("") is not equal to ("https://duckduckgo.com/")
Test (Non-Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L743
testWhenPageRedirected_addressBarStaysActivePreservingUserInput, XCTAssertEqual failed: ("") is not equal to ("https://duckduckgo.com/")
Test (Non-Sandbox)
Process completed with exit code 1.
Test (Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L420
testWhenDeactivatingAddressBar_webViewShouldBecomeFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.AddressBarTextEditor: 0x121663010>
Test (Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L420
testWhenDeactivatingAddressBar_webViewShouldBecomeFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.AddressBarTextEditor: 0x121274560>
Test (Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L420
testWhenDeactivatingAddressBar_webViewShouldBecomeFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.AddressBarTextEditor: 0x11165c880>
Test (Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L743
testWhenPageRedirected_addressBarStaysActivePreservingUserInput, XCTAssertEqual failed: ("") is not equal to ("https://duckduckgo.com/")
Test (Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L743
testWhenPageRedirected_addressBarStaysActivePreservingUserInput, XCTAssertEqual failed: ("") is not equal to ("https://duckduckgo.com/")
Test (Sandbox): IntegrationTests/Tab/AddressBarTests.swift#L743
testWhenPageRedirected_addressBarStaysActivePreservingUserInput, XCTAssertEqual failed: ("") is not equal to ("https://duckduckgo.com/")
Test (Sandbox)
Process completed with exit code 1.
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/ssh-agent@v0.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/ssh-agent@v0.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/ssh-agent@v0.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox)
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel

Artifacts

Produced during runtime
Name Size
Non-Sandbox-integrationtests-xcodebuild.log
141 KB
Non-Sandbox-integrationtests.xcresult
86.3 MB
Non-Sandbox-unittests-xcodebuild.log
861 KB
Sandbox-integrationtests-xcodebuild.log
136 KB
Sandbox-integrationtests.xcresult
85.1 MB
Sandbox-unittests-xcodebuild.log
1.39 MB