Skip to content

Merge release/1.125.0 into main #439

Merge release/1.125.0 into main

Merge release/1.125.0 into main #439

Triggered via push February 4, 2025 21:01
Status Success
Total duration 12m 53s
Artifacts

macos_pr.yml

on: push
Matrix: Test
SwiftLint
40s
SwiftLint
Test Shell Scripts
16s
Test Shell Scripts
Make Release Build
7m 45s
Make Release Build
Verify autoconsent bundle
18s
Verify autoconsent bundle
ShellCheck
9s
ShellCheck
Private API Report  /  Update PR comment
2s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

12 errors, 32 warnings, and 3 notices
BookmarksAndFavoritesTests.test_bookmark_canBeRemovedViaAddressBarIconClick: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/Common/XCUIElementExtension.swift:81 - XCTAssertTrue failed - Query chain:
BookmarksAndFavoritesTests.test_bookmarks_canBeViewedInAddressBarBookmarkDialog: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/BookmarksAndFavoritesTests.swift:347 - XCTAssertTrue failed - Address bar bookmark button didn't load with the expected title in a reasonable timeframe.
BookmarksAndFavoritesTests.test_bookmarks_canBeViewedInBookmarkMenuItem: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/Common/XCUIElementExtension.swift:81 - XCTAssertTrue failed - Query chain:
BookmarksAndFavoritesTests.test_favorites_canBeRemovedFromAddressBarBookmarkDialog: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/BookmarksAndFavoritesTests.swift:459 - XCTAssertTrue failed - Address bar bookmark button didn't load with the expected title in a reasonable timeframe.
PinnedTabsTests.testPinnedTabsFunctionality: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/PinnedTabsTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/PinnedTabsTests.swift:168 - XCTAssertTrue failed
PinnedTabsTests.testPinnedTabsFunctionality: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/PinnedTabsTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/PinnedTabsTests.swift:168 - XCTAssertTrue failed
BookmarksAndFavoritesTests.test_bookmark_canBeRemovedViaAddressBarIconClick: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/Common/XCUIElementExtension.swift:81 - XCTAssertTrue failed - Query chain:
BookmarksAndFavoritesTests.test_bookmarks_canBeViewedInAddressBarBookmarkDialog: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/BookmarksAndFavoritesTests.swift:347 - XCTAssertTrue failed - Address bar bookmark button didn't load with the expected title in a reasonable timeframe.
BookmarksAndFavoritesTests.test_bookmarks_canBeViewedInBookmarkMenuItem: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/Common/XCUIElementExtension.swift:81 - XCTAssertTrue failed - Query chain:
BookmarksAndFavoritesTests.test_favorites_canBeRemovedFromAddressBarBookmarkDialog: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/BookmarksAndFavoritesTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/BookmarksAndFavoritesTests.swift:459 - XCTAssertTrue failed - Address bar bookmark button didn't load with the expected title in a reasonable timeframe.
FireWindowTests.testCrendentialsAreAutoFilledInFireWindows: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/Review/UI Tests.build/Objects-normal/arm64/FireWindowTests.o#L1
/Users/runner/work/macos-browser/macos-browser/UITests/FireWindowTests.swift:109 - Failed to tap "Save" Button: No matches found for Descendants matching type Button from input {(
NewTabPageCustomizationProviderTests.testThatDeleteImageCallsImagesManager: DerivedData/Build/Intermediates.noindex/DuckDuckGo-macOS.build/CI/Unit Tests App Store.build/Objects-normal/arm64/NewTabPageCustomizationProviderTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/NewTabPage/NewTabPageCustomizationProviderTests.swift:244 - XCTAssertEqual failed: ("0") is not equal to ("1")
Make Release Build: LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Make Release Build: LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Make Release Build: LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Make Release Build: LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Make Release Build: LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo-macOS')
Test (Non-Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox): DuckDuckGo/WebExtensions/Headers/_WKWebExtensionTabCreationOptions.h#L14
'_WKWebExtensionWindow' is only available on macOS 14.4 or newer
Test (Non-Sandbox): DuckDuckGo/WebExtensions/Headers/_WKWebExtensionWindowCreationOptions.h#L15
'_WKWebExtensionWindowType' is only available on macOS 14.4 or newer
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo-macOS')
Test (Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Sandbox): LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
Test (Sandbox): LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Sandbox): LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Sandbox): LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Test (Non-Sandbox)
Test run with 1 tests passed after 0.001 seconds
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
Test (Sandbox)
Test run with 1 tests passed after 0.001 seconds