Skip to content

Commit

Permalink
Fix popover not displayed reliably when VPN shortcut is unpinned (#2606)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/1203137811378537/1207059171151302/f
Tech Design URL:
CC:

Description:

When the VPN shortcut is unpinned & the user tries to open the popover from the More Options menu, the temporarily shown VPN shortcut is hidden prematurely and (?) cause the popover to be closed right away.
  • Loading branch information
quanganhdo committed Apr 11, 2024
1 parent 33331a1 commit b5796b6
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,7 @@ extension NavigationBarViewController: NSMenuDelegate {
.store(in: &cancellables)

networkProtectionButtonModel.$showButton
.removeDuplicates()
.receive(on: RunLoop.main)
.sink { [weak self] show in
let isPopUpWindow = self?.view.window?.isPopUpWindow ?? false
Expand Down

0 comments on commit b5796b6

Please sign in to comment.