-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to drag selected text to “+” icon to open a new tab with search results #3189
Comments
1 task
jotaemepereira
added a commit
that referenced
this issue
Sep 12, 2024
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208209124965669/f Tech Design URL: CC: **Description**: This update adds support for dragging strings to the new tab button and the tab bar. - When a string is dropped to the new tab button, it opens a new tab with a search on the dropped string. - When a string is dropped to the current tab (both regular and pinned tabs), the tab gets replaced by a search for the dropped string. - When a string is dropped in the tab bar. For example, at the right of the + button when there is room, it should open a new search with the dropped string. This request came from: #3189 https://github.com/user-attachments/assets/d507c762-066a-4022-8813-5b82747b55c0 **Steps to test this PR**: **Verify new tab is open with a DDG search when a string is dragged to the + button or the tab bar** 1. Drag some text (it could be from a website inside the browser, or any other app) to the new tab button or the tab bar 2. Verify a new tab is open with the dragged text **Verify current tab is replaced with a DDG search when text is dragged to the tab (either regular or pinned tabs)** 1. Drag some text (it could be from a website inside the browser, or any other app) to a tab (either selected or not) 2. Verify the tab is replaced with a DDG search with the dragged string 3. If the tab was not selected it should now **Definition of Done**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? — ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be great to have the ability to drag selected text to the “+” icon (new tab button) in the browser to automatically open a new tab with search results for the dragged text (like in safari and all other browsers)
Use Case:
This feature would improve user experience by making it faster and more intuitive to search for selected text.
Video example
Screen.Recording.2024-09-02.at.19.49.45.mov
The text was updated successfully, but these errors were encountered: