sync connect #1062
Merged
sync connect #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
ayoy
reviewed
Mar 29, 2023
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
6 tasks
ayoy
requested changes
Mar 30, 2023
brindy
requested review from
jaceklyp
and removed request for
a team and
jaceklyp
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
brindy
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 31, 2023
Required: Task/Issue URL: https://app.asana.com/0/0/1204266236802307/f iOS PR: duckduckgo/iOS#1604 macOS PR: duckduckgo/macos-browser#1062 What kind of version bump will this require?: Major Optional: Tech Design URL: CC: Description: Add sync connect flow. Steps to test this PR: iOS connect from macOS Create an account on an iOS device or simulator Launch macOS, remove existing account if needed Begin turn on sync flow and continue to sync with another device - a QR code should be visible On iOS tap on Scan QR Code Using Manually Enter Code paste in the code Wait a few seconds and the account should appear on macOS Repeat the test using the Camera iOS connect from iOS Create an account on device A Delete any existing account from device B On Device B turn on sync and continue through to sync another device Tap show QR Code Copy the code On Device A tap on Scan QR Code Paste it in as in the macOS flow After a few seconds the account should be connected Repeat with Camera OS Testing: iOS 14 iOS 15 iOS 16 macOS 10.15 macOS 11 macOS 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1204266236802307/f
Tech Design URL:
CC:
Description:
Add sync connect flow.
Steps to test this PR:
See duckduckgo/BrowserServicesKit#281 for details.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM