This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Adds entitlements for review and CI builds for some of our agents #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the base branch from
develop
to
diego/feature-network-protection-onboarding
diegoreymendez
commented
Aug 10, 2023
| "identity" : "trackerradarkit", | ||
| "kind" : "remoteSourceControl", | ||
| "location" : "https://github.com/duckduckgo/TrackerRadarKit", | ||
| "location" : "https://github.com/duckduckgo/TrackerRadarKit.git", |
Contributor
Author
There was a problem hiding this comment.
Not sure why Xcode keeps adding and removing this, but I ended up submitting because the Package.resolved file keeps getting modified on its own.
Contributor
There was a problem hiding this comment.
Yeah, i’ve seen this too. Weird one...
graeme
approved these changes
Aug 10, 2023
diegoreymendez
deleted the
diego/feature-network-protection-onboarding-1
branch
diegoreymendez
added a commit
that referenced
this pull request
Aug 10, 2023
… the tunnel view. (#1466) Task/Issue URL: https://app.asana.com/0/0/1205247622252423/f Tech Design URL: CC: ## Stack PR: - Feature branch: `diego/feature-network-protection-onboarding` - #1465 - #1466 (this PR) ## Description: `NetworkProtectionStatusView` has grown to become quite hard to maintain, and the same applies for the view's model. I need to make some changes to be able to disable specifically the tunnel controller part of the view, and these changes make it a bit easier and cleaner. This PR splits it into a parent composite view, and a child `TunnelControllerView`. ## Scope: This PR concentrates refactoring work, meaning that none of the changes should affect functionality in any way. The only intentional change has been to use the menu item attributes that were missing. I'll mark this change with a comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205247616211793/f
Tech Design URL:
CC:
Stack PR
diego/feature-network-protection-onboardingDescription
Just adds entitlements to two agent Apps in REVIEW and CI configurations, since we'll use
UserDefaultsfor sharing data between them.This was disabled initially for NetP as we weren't supporting builds other than DEBUG and RELEASE.
Scope
This PR simply adds entitlements to some of our Agent apps in some build configurations. There should be no changes to functionality other than those targets having the entitlements configured for them.
Testing
Checking that our CI is green should be enough to validate this PR.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation