don't show day 7 when day 0 has been dismissed #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Aug 13, 2023
# By Dominik Kapusta (5) and others # Via GitHub (1) and Lorenzo Mattei (1) * develop: Add support for syncing Credentials (#1368) Fix dsym upload to S3 Bump version to 1.51.1 (48) Report failed unit tests to Asana (#1457) Use MainActor to ensure FutureExtension tests are dispatched on main queue (#1472) Move Make /Applications symlink build phase to later (#1470) don't show day 7 when day 0 has been dismissed (#1468) Update BSK with autofill 8.1.2 (#1471) Add job to create a task on asana if tests fails on develop (#1461) Disables a flaky test from App Store unit tests (#1467) Fix an autoconsent exception on old Safari (#1460) fix bug where wrong address bar text is shown when opening DuckPlayer… (#1434) Fix FutureExtensionTests (#1450) Add pixel to determine Bitwarden use on Mac (#1412) Skip /Applications symlink script for Debug builds (#1443) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 13, 2023
* develop: Update NetP endpoint (#1459) Add support for syncing Credentials (#1368) Fix dsym upload to S3 Bump version to 1.51.1 (48) Report failed unit tests to Asana (#1457) Use MainActor to ensure FutureExtension tests are dispatched on main queue (#1472) Move Make /Applications symlink build phase to later (#1470) don't show day 7 when day 0 has been dismissed (#1468) Update BSK with autofill 8.1.2 (#1471) Add job to create a task on asana if tests fails on develop (#1461) Disables a flaky test from App Store unit tests (#1467) Fix an autoconsent exception on old Safari (#1460) fix bug where wrong address bar text is shown when opening DuckPlayer… (#1434) Fix FutureExtensionTests (#1450) Add pixel to determine Bitwarden use on Mac (#1412) Encapsulate NetP subjects within observers (#1436) Skip /Applications symlink script for Debug builds (#1443)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204186595873227/1205248215850616/f
Description: Modify the card logic to not show the day7 survey when the day0 card has been dismissed
Steps to test this PR:
1 Reset card dismissal: Debug -> Reset Data -> Reset Make DuckDuckGo Yours User Settings
2 Change install day to today: Debug -> Reset Data -> Change Activation Date -> Today
3 Open a new new tab page and check the day 0 survey card appear with the correct copy and icon
4 Click on the card and check it takes you to the correct survey. In the url check the atb is passed at the end of the url.
5 Go back to the new tab page and check the card has disappeared.
6 Change install day to during the past week: Debug -> Reset Data -> Change Activation Date -> Less than a week ago
7 Open a new new tab page and check none of the survey card is present.
8 Change install day to during more than a week ago: Debug -> Reset Data -> Change Activation Date -> More than a week ago.
9 Open a new new tab page and check none of the survey card is present.
10 Repeat steps 1 to 3
11 Dismiss the day 0 card
12 repeat steps 6 to 8
13 check the day 7 card does not appear
14 Repeat steps 1 to 3
15 Repeat steps 6 to 8
16 check the day 7 card appears
17 Click on the card and check it takes you to the correct survey. In the url check the atb is passed at the end of the url.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation