This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Design adjustments for Network Protection onboarding views #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/netp-new-onboarding
…go/netp-new-onboarding
…ak if there are changes
Contributor
diegoreymendez
changed the base branch from
develop
to
diego/netp-new-onboarding
diegoreymendez
commented
Aug 14, 2023
Comment on lines
+33
to
+42
| static let networkProtectionOnboardingAllowExtensionTitle = NSLocalizedString("network.protection.onboarding.allow.extension.title", value: "Allow System Extension", comment: "Title for the onboarding allow-extension step") | ||
| static let networkProtectionOnboardingAllowExtensionDescPrefix = NSLocalizedString("network.protection.onboarding.allow.extension.desc.prefix", value: "Open System Settings to Privacy & Security. Scroll and select ", comment: "Non-bold prefix for the onboarding allow-extension description") | ||
| static let networkProtectionOnboardingAllowExtensionDescAllow = NSLocalizedString("network.protection.onboarding.allow.extension.desc.allow", value: "Allow", comment: "'Allow' word between the prefix and suffix for the onboarding allow-extension description") | ||
| static let networkProtectionOnboardingAllowExtensionDescSuffix = NSLocalizedString("network.protection.onboarding.allow.extension.desc.suffix", value: " for DuckDuckGo software.", comment: "Non-bold suffix for the onboarding allow-extension description") | ||
|
|
||
| static let networkProtectionOnboardingAllowVPNTitle = NSLocalizedString("network.protection.onboarding.allow.vpn.title", value: "Add VPN Configuration", comment: "Title for the onboarding allow-VPN step") | ||
| static let networkProtectionOnboardingAllowVPNDescPrefix = NSLocalizedString("network.protection.onboarding.allow.vpn.desc.prefix", value: "Select ", comment: "Non-bold prefix for the onboarding allow-VPN description") | ||
| static let networkProtectionOnboardingAllowVPNDescAllow = NSLocalizedString("network.protection.onboarding.allow.vpn.desc.allow", value: "Allow", comment: "'Allow' word between the prefix and suffix for the onboarding allow-VPN description") | ||
| static let networkProtectionOnboardingAllowVPNDescSuffix = NSLocalizedString("network.protection.onboarding.allow.vpn.desc.suffix", value: " when prompted to finish setting up Network Protection.", comment: "Non-bold suffix for the onboarding allow-VPN description") | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Updated to latest copy and localized it.
diegoreymendez
commented
Aug 14, 2023
|
|
||
| Button(model.actionTitle, action: model.action) | ||
| .applyStepButtonAttributes(colorScheme: colorScheme) | ||
| .padding(.top, 3) |
Contributor
Author
There was a problem hiding this comment.
The spacing changed in the designs to allow more space on top of the onboarding action button.
diegoreymendez
commented
Aug 14, 2023
| } | ||
| .padding(.top, 16) | ||
| .padding(.bottom, model.actionScreenshot != nil ? 4 : 16) | ||
| .padding(.vertical, 16) |
Contributor
Author
There was a problem hiding this comment.
The spacing at the bottom of the action button is no longer variable depending on the action screenshot.
Base automatically changed from
diego/netp-new-onboarding
to
diego/feature-network-protection-onboarding
August 14, 2023 14:01
Contributor
Author
|
Due to the commit history being a bit off, I've decided to recreate these changes in a different PR. Superseded by #1484 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Description
Addresses design adjustments requested for the new Network Protection onboarding views.
Work done:
Scope:
Address design feedback. Nothing outside of design feedback is in scope for this PR.
Testing:
This PR will be accompanied by a design-review build, so I'd encourage the technical reviewer to focus on the logical changes mainly (and not so much on coloring, fonts, spacing, etc).
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation