This repository was archived by the owner on Feb 24, 2025. It is now read-only.
fix saved popup frame applied to new window #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Aug 25, 2023
# By Alexey Martemyanov (2) and others # Via Diego Rey Mendez (1) and GitHub (1) * develop: Update DBP BSK version (#1548) Add DBP package (#1482) disable 2 flaky tests (#1543) Update BSK with autofill 8.2.0 (#1536) iOS InContext Email Protection Signup support (#1419) fix windows repositioned on sleep/display on-off (#1533) Move pixel sender logic into the main view controller (#1528) Updated metadata and rules for 1.53.2 fix saved popup frame applied to new window (#1530) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Common/Localizables/UserText.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1204335652578292/f
Description:
Steps to test this PR:
window.open("duckduckgo.com")->open blocked popupInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation