Use sites scanned by broker instead of number of scans in the UI #1903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
https://app.asana.com/0/1204006570077678/1206052775622166/f
Description
We are currently sending
currentScans
andtotalScans
to the UI with the actual values of what’s happening. The UI shows sites scanned, which is different from total scans.For example, if you add two names and one address, let's say we have only Verecor and Veriforia as brokers. We will send
totalScans = 4
(two scans on Verecor, two scans on Veriforia)Now we send the scans by broker. In the example above, we would show
totalScans = 2
(we only count the brokers Vercor and Veriforia).One thing is that we will count a broker as ‘scanned’ if one of the profile queries for a particular broker has a scan date. The reason is that if we wait for all profile queries for a particular broker to finish to mark it as scanned, the user could see matches for more than one broker even when the count is one.
Example of the above:
If the first queries return matches, the count will be 1..2, and we will show matches for two brokers which could confuse the user.
NOTE: This PR also fixes a bug where if there were multiple matches for the same broker profile query, it would only show one.
Steps to test
Test matches are correct