Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Mar 5, 2024

Task/Issue URL: https://app.asana.com/0/1177771139624306/1206752972667935/f
BSK PR: duckduckgo/BrowserServicesKit#699

Description:

  • fixes bundle name stripping from symbols in breakByRaisingSigInt

Steps to test this PR:

  1. Validate there‘s no sigint raised when navigating to a website in the App Store DEBUG build (should run localized build?)

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from aataraxiaa March 5, 2024 14:29
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
@github-actions github-actions bot removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 5, 2024
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mallexxx mallexxx changed the title set BSK version fix bundle name in breakByRaisingSigInt Mar 5, 2024
@mallexxx mallexxx merged commit 6608d67 into main Mar 5, 2024
@mallexxx mallexxx deleted the alex/fix-sigint-bundle-name branch March 5, 2024 14:43
samsymons added a commit that referenced this pull request Mar 6, 2024
# By Alexey Martemyanov (10) and others
# Via GitHub
* main: (39 commits)
  Add Peoplewhiz data broker (#2310)
  Integrate confirm entitlements endpoint for macOS App Store purchase (#2325)
  Make dbSaveBloomFilterError pixel daily and continuous (#2299)
  Subscription UI updates (#2303)
  Add email pattern on opt-out pixel (#2307)
  Use compile-time checked generated asset names (#2177)
  fix bundle name in breakByRaisingSigInt (#2319)
  BSK update for iOS autofill support to delete all passwords (#2254)
  Bump BrowserServicesKit (#2309)
  Bump version to 1.78.0 (132)
  Fix crash on popup window display; adjust naming (#2315)
  Bump version to 1.78.0 (131)
  Set marketing version to 1.78.0
  Update embedded files
  Fix parsing commit log (#2311)
  DBP: Set correct duration of submit-success pixel (#2308)
  Publish subsequent internal releases right after building (#2306)
  DBP disable pixel changes (#2293)
  Remove duplicated broker items (#2294)
  fix tab title not updated (#2302)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants