This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Validate that release notes are present before publishing a new release #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
ayoy
commented
Mar 5, 2024
Comment on lines
+41
to
+42
| Complete this task when ready and proceed with testing the build. If you're bumping an internal release, you should get another task asking you to publish the release in Sparkle. | ||
| Look for other tasks in <a data-asana-gid='${AUTOMATION_TASK_ID}'/> task and handle them as needed. |
Collaborator
Author
There was a problem hiding this comment.
This is an unrelated change, but I forgot to save the file before submitting my previous pull request #2306
ayoy
removed
the
bot: not in app board
ayoy
commented
Mar 5, 2024
Comment on lines
+129
to
+132
| release_notes="$(<release_notes.txt)" | ||
| if [[ ${#release_notes} == 0 || "$release_notes" == "<-- Add release notes here -->" ]]; then | ||
| echo "::error::Release notes are empty. Please add release notes to the Asana task and restart the workflow." | ||
| exit 1 |
Collaborator
Author
There was a problem hiding this comment.
Lines 129-132 is the new code. The rest was moved so that the check happens before fetching the DMG.
jotaemepereira
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1206760506719785/f
CC: @loremattei
Description:
As first step in Bump Internal Release and Publish DMG Release workflows, validate
that release notes in the Asana task are not empty or not a placeholder.
Steps to test this PR:
Fake Asana release task: link
Verify the following workflows:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation