Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release PR] Fix lottie high Windowserver load #2598

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[Release PR] Fix lottie high Windowserver load #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions DuckDuckGo/Application/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,12 @@ final class AppDelegate: NSObject, NSApplicationDelegate {

PrivacyFeatures.httpsUpgrade.loadDataAsync()
bookmarksManager.loadBookmarks()

// Force use of .mainThread to prevent high WindowServer Usage
// Pending Fix with newer Lottie versions
// https://app.asana.com/0/1177771139624306/1207024603216659/f
LottieConfiguration.shared.renderingEngine = .mainThread

if case .normal = NSApp.runType {
FaviconManager.shared.loadFavicons()
}
Expand Down
8 changes: 7 additions & 1 deletion DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,13 @@ final class AddressBarButtonsViewController: NSViewController {
}

private func setupAnimationViews() {
func addAndLayoutAnimationViewIfNeeded(animationView: LottieAnimationView?, animationName: String, renderingEngine: Lottie.RenderingEngineOption = .automatic) -> LottieAnimationView {

func addAndLayoutAnimationViewIfNeeded(animationView: LottieAnimationView?,
animationName: String,
// Default use of .mainThread to prevent high WindowServer Usage
// Pending Fix with newer Lottie versions
// https://app.asana.com/0/1177771139624306/1207024603216659/f
renderingEngine: Lottie.RenderingEngineOption = .mainThread) -> LottieAnimationView {
if let animationView = animationView, animationView.identifier?.rawValue == animationName {
return animationView
}
Expand Down
Loading