-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI tests failing in the CI #3254
Conversation
c46fec2
to
ab3126a
Compare
@ayoy Danger says two tests failed, I think it didn’t update after the last run or it didn’t update the tests after the second instance passed. Here is the last UI tests workflow and is passing: https://github.com/duckduckgo/macos-browser/actions/runs/10816432950/job/30007600733 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @jotaemepereira! 🙇
ab3126a
to
19ec30d
Compare
19ec30d
to
e41040f
Compare
@ayoy I’m going to merge, it seems that now only two tests are failing (not related). If it keeps failing, I’m going to take another look. |
# By Dominik Kapusta (4) and others # Via Dominik Kapusta (4) and GitHub (2) * main: Support dragging strings to new tab button (#3228) BSK - Add feature flag for SKAN API (#3265) Ignore accents when doing a bookmark search (#3255) Update UI tests workflows to always compile the app on the supported version of Xcode (#3262) Bump C.S.S (via BSK) (#3244) Tab previews presentation implementation adjusted for the latest MouseOverView logic (#3260) Bump version to 1.106.0 (260) Default to appstore signing for fastlane match Clean up secrets in GHA workflows Update Onboarding gradients (#3248) Wait for UserScripts to be loaded for email protection (#3252) Fix UI tests failing in the CI (#3254) Fix WKDownloadMock mock (#3258) VPN Proxy stop and pixel improvements (#3239) Use fastlane match for code signing DMG builds (#3246) Implement new VPN site troubleshooting report alert (#3224) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# By Dominik Kapusta (7) and others # Via Dominik Kapusta (6) and GitHub (4) * main: (37 commits) Add visted links support (#3261) Bump version to 1.106.0 (261) Update Gemfile.lock Remove migration file (#3270) Use new AsanaCreateActionItem action (#3264) Update survey builder OS version (#3247) Support dragging strings to new tab button (#3228) BSK - Add feature flag for SKAN API (#3265) Ignore accents when doing a bookmark search (#3255) Update UI tests workflows to always compile the app on the supported version of Xcode (#3262) Bump C.S.S (via BSK) (#3244) Tab previews presentation implementation adjusted for the latest MouseOverView logic (#3260) Bump version to 1.106.0 (260) Default to appstore signing for fastlane match Clean up secrets in GHA workflows Update Onboarding gradients (#3248) Wait for UserScripts to be loaded for email protection (#3252) Fix UI tests failing in the CI (#3254) Fix WKDownloadMock mock (#3258) VPN Proxy stop and pixel improvements (#3239) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208242072125397/f
Tech Design URL:
CC:
Description:
Removes resetting the show bookmarks bar popover from the debug menu item, and when dismissing a popover we only do it if exists, if not it continues with the test.
Steps to test this PR:
You can test the flow locally, but it takes some time, and we also need to make sure it’s passing in the CI. I’ve run the flow in the CI, here is the link: https://github.com/duckduckgo/macos-browser/actions/runs/10816432950/job/30007600733
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation