Fix UI tests failing in the CI #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
force-pushed
the
juan/fix-ui-test-failing
branch
2 times, most recently
from
c46fec2
to
ab3126a
Compare
|
@ayoy Danger says two tests failed, I think it didn’t update after the last run or it didn’t update the tests after the second instance passed. Here is the last UI tests workflow and is passing: https://github.com/duckduckgo/macos-browser/actions/runs/10816432950/job/30007600733 |
ayoy
approved these changes
Sep 11, 2024
jotaemepereira
force-pushed
the
juan/fix-ui-test-failing
branch
from
ab3126a
to
19ec30d
Compare
jotaemepereira
force-pushed
the
juan/fix-ui-test-failing
branch
from
19ec30d
to
e41040f
Compare
|
@ayoy I’m going to merge, it seems that now only two tests are failing (not related). If it keeps failing, I’m going to take another look. |
samsymons
added a commit
that referenced
this pull request
Sep 12, 2024
# By Dominik Kapusta (4) and others # Via Dominik Kapusta (4) and GitHub (2) * main: Support dragging strings to new tab button (#3228) BSK - Add feature flag for SKAN API (#3265) Ignore accents when doing a bookmark search (#3255) Update UI tests workflows to always compile the app on the supported version of Xcode (#3262) Bump C.S.S (via BSK) (#3244) Tab previews presentation implementation adjusted for the latest MouseOverView logic (#3260) Bump version to 1.106.0 (260) Default to appstore signing for fastlane match Clean up secrets in GHA workflows Update Onboarding gradients (#3248) Wait for UserScripts to be loaded for email protection (#3252) Fix UI tests failing in the CI (#3254) Fix WKDownloadMock mock (#3258) VPN Proxy stop and pixel improvements (#3239) Use fastlane match for code signing DMG builds (#3246) Implement new VPN site troubleshooting report alert (#3224) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
# By Dominik Kapusta (7) and others # Via Dominik Kapusta (6) and GitHub (4) * main: (37 commits) Add visted links support (#3261) Bump version to 1.106.0 (261) Update Gemfile.lock Remove migration file (#3270) Use new AsanaCreateActionItem action (#3264) Update survey builder OS version (#3247) Support dragging strings to new tab button (#3228) BSK - Add feature flag for SKAN API (#3265) Ignore accents when doing a bookmark search (#3255) Update UI tests workflows to always compile the app on the supported version of Xcode (#3262) Bump C.S.S (via BSK) (#3244) Tab previews presentation implementation adjusted for the latest MouseOverView logic (#3260) Bump version to 1.106.0 (260) Default to appstore signing for fastlane match Clean up secrets in GHA workflows Update Onboarding gradients (#3248) Wait for UserScripts to be loaded for email protection (#3252) Fix UI tests failing in the CI (#3254) Fix WKDownloadMock mock (#3258) VPN Proxy stop and pixel improvements (#3239) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208242072125397/f
Tech Design URL:
CC:
Description:
Removes resetting the show bookmarks bar popover from the debug menu item, and when dismissing a popover we only do it if exists, if not it continues with the test.
Steps to test this PR:
You can test the flow locally, but it takes some time, and we also need to make sure it’s passing in the CI. I’ve run the flow in the CI, here is the link: https://github.com/duckduckgo/macos-browser/actions/runs/10816432950/job/30007600733
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation