Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hotkey handling in Bookmarks manager, Bookmarks popover #3278

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix hotkey handling in Bookmarks manager, Bookmarks popover #3278

merged 2 commits into from
Sep 16, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL:
Tech Design URL:
CC:

Description:

  • Fix hotkey handling in Bookmarks manager, bookmarks popover

Steps to test this PR:

  1. validate cmd+f beeps in empty state in both Bookmarks manager, bookmarks popover
  2. validate cmd+f beeps on new tab when the address bar is not active
  3. validate typing letter keys in empty state doesn‘t show search in the popover
  4. validate removing last bookmark in the popover hides the search bar
  5. validate Esc key deactivates search in Bookmarks Manager
  6. validate cmd+f works in Bookmarks Manager

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Fails
🚫 Please, don't forget to add a link to the internal task

Generated by 🚫 dangerJS against a160670

@mallexxx mallexxx mentioned this pull request Sep 16, 2024
Merged
1 task
jotaemepereira
jotaemepereira approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jotaemepereira jotaemepereira merged commit de91ed9 into juan/disable-search-sort-when-no-bookmarks Sep 16, 2024
10 of 15 checks passed
@jotaemepereira jotaemepereira deleted the alex/fix-bookmarks-shortcuts branch September 16, 2024 13:03
jotaemepereira pushed a commit that referenced this pull request Sep 16, 2024
@mallexxx @jotaemepereira
fix hotkey handling in Bookmarks manager, Bookmarks popover (#3278)
f6fc346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotaemepereira jotaemepereira jotaemepereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @jotaemepereira