Left align the bookmarks bar #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
changed the title
jotaemepereira
force-pushed
the
juan/left-align-bookmarks-bar-adjust-spacing
branch
from
dc3aa60
to
81cfdf1
Compare
jotaemepereira
requested review from
a team and
diegoreymendez
and removed request for
samsymons and
a team
diegoreymendez
approved these changes
Sep 20, 2024
jotaemepereira
deleted the
juan/left-align-bookmarks-bar-adjust-spacing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208262956542591/f
Tech Design URL:
CC:
Description:
Left-aligns the bookmarks bar.
Before this change, bookmarks were centered until they occupied the whole bookmarks bar. Once the whole bar was occupied by bookmarks, the bookmarks bar became centered, and the overflow indicator was shown.
Now, bookmarks are aligned to the left. This aligns with other browsers and with Windows.
This also changed the spacing between bookmarks in the bar from six to two (something required here: https://app.asana.com/0/0/1208262956542589/f)
Steps to test this PR:
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation