Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close tab after starting a download when App opens a URL #3308

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1202406491309510/1208315400860384/f

Description:

  • Close empty tab created when opening a URL with the app after download has started
  • Add URL and Title to the dragging pasteboard when dragging a URL from the Address Bar
  • Improve code readability in some places

Steps to test this PR:

  1. Drag a download link (e.g. from Asana) to the Tab Bar, validate the new tab is closed
  2. Drag a download link onto the "+" in the Tab Bar, validate the new tab is closed
  3. Drag a download link onto the "+" button when the Tab Bar is in overflown (scrollable) state, validate the new tab is closed
  4. Drag a download link onto the app icon using the app in the Dock), validate the new tab is closed
  5. Navigate somewhere; Drag the URL from the Address Bar to Safari bookmark manager, validate a new item is added with title matching the page title

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from ayoy September 19, 2024 10:31
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All worked great (I compared to the release app to get a feeling of how broken things were) and the code looks much better now, thanks @mallexxx!

@mallexxx mallexxx merged commit c3f906b into main Sep 23, 2024
18 checks passed
@mallexxx mallexxx deleted the alex/close-download-tab branch September 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants