Remove login import de-duplication feature flag #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
requested review from
amddg44 and
aataraxiaa
and removed request for
amddg44
6 tasks
graeme
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 20, 2024
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/414235014887631/1207759292115042/f iOS PR: duckduckgo/iOS#3369 macOS PR: duckduckgo/macos-browser#3313 What kind of version bump will this require?: Major **Description**: For [✓ macOS: Deduplicate passwords on import](https://app.asana.com/0/0/1207597760316574), a feature flag was added to mitigate risk of negative user reaction / unforeseen issues. This should be removed once we're confident in the implementation. The feature flag is named deduplicateLoginsOnImport **Steps to test this PR**: 1. See macOS PR **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207759292115042/f
Description:
For ✓ macOS: Deduplicate passwords on import, a feature flag was added to mitigate risk of negative user reaction / unforeseen issues. This should be removed once we're confident in the implementation.
The feature flag is named
deduplicateLoginsOnImportSteps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation