Make bookmarks panel grow as screen permits #3316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elow the bookmarks popover button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208262956542590/f
Tech Design URL:
CC:
Description
Acceptance criteria
AC#1
Given a user with a lot of bookmarks
When the user opens the bookmarks panel
Then, the popover will try to take as much available space either to the top or the bottom of the bookmarks popover button
AC#1
Given a user with some bookmarks
When the user opens the bookmarks panel
Then, the popover will be at least 420 wide and 500 taller.
Demo
make-the-bookmarks-panel-grow-as-the-screen-permits.mov
Steps to test this PR:
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation