Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex pattern for parsing Privacy Pro release notes #3318

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Sep 20, 2024

Task/Issue URL: https://app.asana.com/0/1201048563534612/1208358673191631/f

Description:
Use H3 tag instead of H2

Steps to test this PR:

  1. Run the app in Xcode
  2. Go to Settings -> About and check for updates
  3. Open a new tab and navigate to duck://release-notes
  4. Verify that "For Privacy Pro subscribers" section is present in the release notes.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested review from tomasstrba and removed request for tomasstrba September 20, 2024 06:21
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

Screenshot 2024-09-20 at 09 18 55

@ayoy ayoy merged commit ff8a7e0 into release/1.107.0 Sep 20, 2024
22 of 23 checks passed
@ayoy ayoy deleted the dominik/fix-release-notes branch September 20, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants