Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockable JS Alerts inside tabs #904

Merged
merged 60 commits into from
Jan 26, 2023
Merged

Blockable JS Alerts inside tabs #904

merged 60 commits into from
Jan 26, 2023

Commits on Jan 24, 2023

  1. Alerts wip

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bd61110 View commit details
    Browse the repository at this point in the history

  2. Fix lifecycle issue on dismissal

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    7193a68 View commit details
    Browse the repository at this point in the history

  3. Dismiss dialogs on content change

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    cb73eef View commit details
    Browse the repository at this point in the history

  4. Fix dark mode

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5650e97 View commit details
    Browse the repository at this point in the history

  5. Fix text scrollView layout timing

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    b5d2f61 View commit details
    Browse the repository at this point in the history

  6. Prevent message from being edited

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e360ea1 View commit details
    Browse the repository at this point in the history

  7. Add outer padding

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6aad7ac View commit details
    Browse the repository at this point in the history

  8. Fix crash on reloading page

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    fa8a469 View commit details
    Browse the repository at this point in the history

  9. Make background same as cookie consent

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bbafff0 View commit details
    Browse the repository at this point in the history

  10. Tidy up

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a3e0a65 View commit details
    Browse the repository at this point in the history

  11. Handle cancel and ok key presses

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    672872c View commit details
    Browse the repository at this point in the history

  12. Move strings into localized constants

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c1d05e7 View commit details
    Browse the repository at this point in the history

  13. Separate JSAlert classes into group

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9d6b263 View commit details
    Browse the repository at this point in the history

  14. Tidy up JSAlertQuery extension

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5d1f640 View commit details
    Browse the repository at this point in the history

  15. Move JSAlertViewModel to private property

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6ad1383 View commit details
    Browse the repository at this point in the history

  16. Fix header warning

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    67f43d9 View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary jsAlertController property

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    82cc1d7 View commit details
    Browse the repository at this point in the history

  18. Remove all blocking functionality

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    bbcd2ed View commit details
    Browse the repository at this point in the history

  19. Write ViewModel unit tests

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    065d125 View commit details
    Browse the repository at this point in the history

  20. Fix horizontal margins

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6b0454a View commit details
    Browse the repository at this point in the history

  21. Pass defaultText from callback

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6f60dcc View commit details
    Browse the repository at this point in the history

  22. Fix scrollView size issue

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    799b203 View commit details
    Browse the repository at this point in the history

  23. Remove forgotten print

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    7e54300 View commit details
    Browse the repository at this point in the history

  24. Fix animation bugs

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1528f9c View commit details
    Browse the repository at this point in the history

  25. Name magic spacing number

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    efd21e5 View commit details
    Browse the repository at this point in the history

  26. Hide scrollers when not needed

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    8838053 View commit details
    Browse the repository at this point in the history

  27. Center alert in window rather than webview

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a744c1b View commit details
    Browse the repository at this point in the history

  28. Run swiftlint

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5255892 View commit details
    Browse the repository at this point in the history

  29. Remove accidentally committed lines

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0b35776 View commit details
    Browse the repository at this point in the history

  30. Fix background darkmode change

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    462d9de View commit details
    Browse the repository at this point in the history

  31. Fix enter key forwarding to OK button

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9822a8b View commit details
    Browse the repository at this point in the history

  32. Tighten up animation

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    01bbbee View commit details
    Browse the repository at this point in the history

  33. Fix layout when window is tiny

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3d84af3 View commit details
    Browse the repository at this point in the history

  34. Fix focus ring animation

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4a7d09a View commit details
    Browse the repository at this point in the history

  35. Ensure scrollview starts at top

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c1d8768 View commit details
    Browse the repository at this point in the history

  36. Block interaction with UI behind background

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4022396 View commit details
    Browse the repository at this point in the history

  37. Don't make hidden textField firstResponder

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a870265 View commit details
    Browse the repository at this point in the history

  38. Handle key presses after AddressBar resigns

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    82bf054 View commit details
    Browse the repository at this point in the history

  39. Close on escape when cancel button hidden

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    61f25cb View commit details
    Browse the repository at this point in the history

  40. Tidy up layer / anchor point code

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    29290ec View commit details
    Browse the repository at this point in the history

  41. Rename dialog panel background color

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    439aa3d View commit details
    Browse the repository at this point in the history

  42. Rename some subviews

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f43c4fb View commit details
    Browse the repository at this point in the history

  43. Various IB text field / text view tweaks

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    06bac3e View commit details
    Browse the repository at this point in the history

  44. Extract transform animation value to constant

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6003a54 View commit details
    Browse the repository at this point in the history

  45. Explain anchorPoint code a bit better

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    22b05e6 View commit details
    Browse the repository at this point in the history

  46. Handle empty alert text

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0b42c1c View commit details
    Browse the repository at this point in the history

  47. Use ColorView for background

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    771314c View commit details
    Browse the repository at this point in the history

  48. Return from keyDown on cancelAction

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f926aba View commit details
    Browse the repository at this point in the history

  49. Use Constant for forgotten hardcoded transform value

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9d93065 View commit details
    Browse the repository at this point in the history

  50. Add comment explaining delayed animation dispatch

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4495087 View commit details
    Browse the repository at this point in the history

  51. Use ColorView for alertView to reduce color code

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    cf08be7 View commit details
    Browse the repository at this point in the history

  52. Remove unnecessary pointer checks from animation

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    08a67d2 View commit details
    Browse the repository at this point in the history

  53. Handle all mouse downs in ColorView

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    22907b5 View commit details
    Browse the repository at this point in the history

  54. Fix escape close for Confirm dialog

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    447e436 View commit details
    Browse the repository at this point in the history

  55. Fix scrollview position properly

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c8d9e8a View commit details
    Browse the repository at this point in the history

  56. Fix scrollview issue... again

    @graeme
    graeme committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f49d74f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Layout whole view subtree fixing alignment issue

    @graeme
    graeme committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    360aafc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into graeme/js-alerts-i… 

    …nside-tabs
    @graeme
    graeme committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b6ec3bd View commit details
    Browse the repository at this point in the history

  3. Add new files to App Store target

    @graeme
    graeme committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    36cdb4c View commit details
    Browse the repository at this point in the history

  4. ...and unit tests

    @graeme
    graeme committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    9b42b1d View commit details
    Browse the repository at this point in the history