Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix frame handle (fix js printing) #983

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1203962320856337/f
BSK PR: duckduckgo/BrowserServicesKit#235
Tech Design URL:
CC: @tomasstrba

Description:

Steps to test this PR:

  1. Validate printing via js (window.print() from console) works

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! JS printing works great now. Thanks for a quick fix!

@ayoy ayoy assigned mallexxx and unassigned ayoy Feb 20, 2023
@mallexxx mallexxx merged commit 29bf4e1 into alex/dist-nav-delegate Feb 21, 2023
@mallexxx mallexxx deleted the alex/fix-frame-handle branch February 21, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants