Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand tracker blocking test (redirect and iframe^2) #105

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Expand tracker blocking test (redirect and iframe^2) #105

merged 1 commit into from
Nov 10, 2022

Conversation

kdzwinel
Copy link
Member

@kdzwinel kdzwinel commented Nov 4, 2022

Adds two test for edge-cases that we encountered over the last few months:

  • tracker loaded via a safe redirect (-> good 307 -> bad)
  • tracker loaded from an iframe within an iframe

@kdzwinel kdzwinel force-pushed the konrad/expand-blocking-test branch from 5558725 to 84dc74a Compare November 4, 2022 11:26
jonathanKingston
jonathanKingston approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great, sorry for the delay in review!

@jonathanKingston jonathanKingston merged commit 7de1e1f into main Nov 10, 2022
@jonathanKingston jonathanKingston deleted the konrad/expand-blocking-test branch November 10, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanKingston jonathanKingston jonathanKingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdzwinel @jonathanKingston