Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cookie expiry if cookieStore available. #106

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Conversation

kdzwinel
Copy link
Member

@kdzwinel kdzwinel commented Nov 4, 2022

expiry

Limitations:

  • only JS set cookies (on header set cookies we have httponly flag)
  • only Chromium (CookieStore API)

@kdzwinel kdzwinel requested a review from sammacbeth November 4, 2022 15:18
},
retrive: () => {
return trackingDomain ? document.cookie.match(/tptdata=([0-9]+)/)[1] : document.cookie.match(/tpsdata=([0-9]+)/)[1];
},
extra: () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced an "extra" callback that can show additional info next to the result. This info doesn't go into the results object.

Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment, but non-blocking.

privacy-protections/storage-blocking/iframe.js Outdated Show resolved Hide resolved
privacy-protections/storage-blocking/iframe.js Outdated Show resolved Hide resolved
kdzwinel and others added 2 commits November 5, 2022 12:47
Co-authored-by: Sam Macbeth <sammacbeth@users.noreply.github.com>
Co-authored-by: Sam Macbeth <sammacbeth@users.noreply.github.com>
@kdzwinel kdzwinel merged commit 10718c8 into main Nov 5, 2022
@kdzwinel kdzwinel deleted the konrad/cookie-expiry branch November 5, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants