Run cookie header tests in frames. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
reviewed
Nov 15, 2022
sammacbeth
force-pushed
the
sam/header-cookies-in-frames
branch
from
b2ce811 to
a728035
Compare
kdzwinel
reviewed
Nov 16, 2022
cookies from different test page contexts.
|
Thanks a lot for those changes! Figuring out those cookies won't be straightforward, but it does make sense when you think about it for a bit. Merging!
|
kdzwinel
approved these changes
Nov 17, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the storage header cookie sites to the list of common tests, so that they also run in safe and tracker iframes.