-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy protections - request blocking #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push initial verision of request blocking.
…orker and web worker
…ults programatically, run tests on button click, allow for downloading results.
Charlie-belmer
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Konrad, everything looks great. I don't have any real changes to propose, just a couple of questions. I like the test layout and runner, seems easy to add new tests!
Thank you for a review @Charlie-belmer ! I addressed all your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic setup for privacy protection test pages and first page: request blocking.
Page is hosted, and can be tested, on glitch: https://privacy-test-pages.glitch.me/privacy-protections/request-blocking/
You can test blocking by either: modifying our extension to block all requests to
https://privacy-test-pages.glitch.me/privacy-protections/request-blocking/block-me/
or by adding/block-me/
rule to e.g. uBlock Origin.Overview of interesting files:
server.js
- simple express server that creates, among others, websocket endpoint (that should be blocked) and appends relevant headers (e.g.content-security-policy-report-only
)/block-me/*
- this folder contains files of various types (wav, img, json) that page will try to load and should get blockedrequest-blocking/index.html
- main page for the request blocking testrequest-blocking/main.js
- all tests and a test runner for the request blocking testprivacy-protections/running-tests.md
- description how to use test pages (manually or for automatic tests)