Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy protections - request blocking #11

Merged
merged 22 commits into from
Nov 24, 2020

Conversation

kdzwinel
Copy link
Member

This PR adds basic setup for privacy protection test pages and first page: request blocking.

Page is hosted, and can be tested, on glitch: https://privacy-test-pages.glitch.me/privacy-protections/request-blocking/
You can test blocking by either: modifying our extension to block all requests to https://privacy-test-pages.glitch.me/privacy-protections/request-blocking/block-me/ or by adding /block-me/ rule to e.g. uBlock Origin.

Overview of interesting files:

  • server.js - simple express server that creates, among others, websocket endpoint (that should be blocked) and appends relevant headers (e.g. content-security-policy-report-only)
  • /block-me/* - this folder contains files of various types (wav, img, json) that page will try to load and should get blocked
  • request-blocking/index.html - main page for the request blocking test
  • request-blocking/main.js - all tests and a test runner for the request blocking test
  • privacy-protections/running-tests.md - description how to use test pages (manually or for automatic tests)

Copy link
Collaborator

@Charlie-belmer Charlie-belmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Konrad, everything looks great. I don't have any real changes to propose, just a couple of questions. I like the test layout and runner, seems easy to add new tests!

@kdzwinel kdzwinel merged commit 8166cb3 into duckduckgo:gh-pages Nov 24, 2020
@kdzwinel
Copy link
Member Author

Thank you for a review @Charlie-belmer ! I addressed all your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants